"Preliminary Reviewed" extension still displays "unverified" message on install

Add-ons addons.mozilla.org
#1

I have verified my plugin using AMO’s Unlisted feature, downloaded the file from the /versions page and directed the user to the .xpi file using the following code:
var params = { "Foo": { URL: '/js/extensions/screen_sharing_extension_for_discussio-1.1.xpi', IconURL: '/img/logos/icon32.png', Hash: 'sha1:0685d223403576771976d3e8a9814f0f5a059c52', toString: function () { return '/js/extensions/screen_sharing_extension_for_discussio-1.1.xpi'; } } }; InstallTrigger.install(params);

Here is the error I’m getting:

I have been trying to fix this error for a few hours now and I have followed all of the instructions here: https://wiki.mozilla.org/Add-ons/Extension_Signing

I found a similar issue here: https://discourse.mozilla-community.org/t/cant-download-reviewed-firefox-add-on/4300/5 and uploaded a version 1.1 to make sure that the latest verified version can be downloaded.

Another similar issue (https://discourse.mozilla-community.org/t/preliminary-review-of-unlisted-extension/3359) verified the download link I was using is correct. Here is the link: https://addons.mozilla.org/firefox/downloads/file/387673/screen_sharing_extension_for_discussio-1.1.xpi?src=devhub (non-mozilla-admins may not have access to this link)

Why am I still encountering this error if my firefox is accessing the file downloaded from the Preliminarily Reviewed version?

#2

What is the page one could download/install your add-on from?

#3

The addon is unlisted so it is available for me here: https://addons.mozilla.org/firefox/downloads/file/387673/screen_sharing_extension_for_discussio-1.1.xpi?src=devhub

Here’s the page for the addon (not sure if you can access it): https://addons.mozilla.org/en-US/developers/addon/discussio_screensharing/

I am pointing users to this url (with a hash to verify the file) on my site: https://des-work.discuss.io/js/extensions/screen_sharing_extension_for_discussio-1.1.xpi

#4

That was not what I was asking for. In your original post, you were stating that you were using JavaScript to initiate a download/install of your add-on. What page is that JS on?

#5

You can access the installer by going to: https://des-work.discuss.io/demo (you can enter a fake email address if asked for one) and click the “share” icon: then “Share My Computer Screen”:

Thanks for your help! The .js file calling the installer is located here: http://des-work.discuss.io/js/discussion/dss.js

#6

The file that is being served (https://des-work.discuss.io/js/extensions/screen_sharing_extension_for_discussio-1.1.xpi) is not signed.

#7

Strange. Here is what I’m doing in my Developer Hub to download what I thought was the verified version of the file:

1.png952×814 120 KB

2.png957×960 164 KB

3.png964×962 142 KB

I confirmed that this was how to access the signed file by following the instructions from another post:

I’m not sure where to find the verified .xpi file that I should be distributing to my users.

#8

Did you download the signed file to your computer? Did you upload that very same signed file to your webserver?

#9

The file I uploaded (unsigned) was called “ScreenSharing.xpi”. I assumed that the file “screen_sharing_extension_for_discussio-1.1.xpi” downloaded from that page was the signed version. I uploaded that file to my webserver but it apparently is not the signed version…

The sha1 hash is the same for both the “ScreenSharing.xpi” file that I uploaded and the “screen_sharing_extension_for_discussio-1.1.xpi” that I downloaded after the review. So I am not sure where to find the signed file.

#10

The file has not been signed after review because the extension is not marked to be compatible to Firefox, see https://addons.mozilla.org/en-US/developers/addon/discussio_screensharing/versions/1802948 in the Compatibility section.

You need to update your install manifest and add Firefox as a targetApplication, then increase the version number and resubmit to get a signed file.

#11

I’m using “toolkit@mozilla.org to say that the add-on is compatible with any toolkit app with a toolkit version matching the minVersion and maxVersion.” - https://developer.mozilla.org/en-US/Add-ons/Install_Manifests#targetApplication

I have created a version 1.2 that uses the largest maxVersion possible (before it was 46.*, which seems incorrect). The targetApplication section of my install.rdf can be found below:
<em:targetApplication> <Description> <em:id>toolkit@mozilla.org</em:id> <em:minVersion>33.0</em:minVersion> <em:maxVersion>43.*</em:maxVersion> </Description> </em:targetApplication>

Should I not use the toolkit@mozilla.org to specify firefox compatibility? If not, what should i replace with it? The file “https://des-work.discuss.io/js/extensions/screen_sharing_extension_for_discussio-1.2.xpi” is still not signed so I must still be specifying the version number incorrectly.

Also, if it wasn’t signed, why do I get confirmation messages like this?

Screen Shot 2016-01-19 at 16.27.17.png1078×236 88.5 KB

#12

Only files that are explicitly compatible to Firefox are signed. You can find the application ID of Firefox and valid versions on https://addons.mozilla.org/en-US/firefox/pages/appversions/

Interesting, that is likely a bug.
I filed https://github.com/mozilla/olympia/issues/1448

1 Like
#13

Thanks for all your help @TheOne. Specifying the firefox id “{ec8030f7-c20a-464f-9b0e-13a3a9e97384}” in the targetApplication section of the install.rdf seemed to fix it.