"Typesetting a community school home page" assessment

Hi, Mr, Chris! I’ve just finished my Typesetting exercise! Could you please give me feedback on the work?
Here the CSS code

@font-face {
font-family: ‘enigmaticregular’;
src: url(‘EnigmaB_2-webfont.eot’);
src: url(‘EnigmaB_2-webfont.eot?#iefix’) format(‘embedded-opentype’),
url(‘EnigmaB_2-webfont.woff2’) format(‘woff2’),
url(‘EnigmaB_2-webfont.woff’) format(‘woff’),
url(‘EnigmaB_2-webfont.ttf’) format(‘truetype’),
url(‘EnigmaB_2-webfont.svg#enigmaticregular’) format(‘svg’);
font-weight: normal;
font-style: normal;

}
@font-face {
font-family: ‘20_dbregular’;
src: url(‘20db-webfont.eot’);
src: url(‘20db-webfont.eot?#iefix’) format(‘embedded-opentype’),
url(‘20db-webfont.woff2’) format(‘woff2’),
url(‘20db-webfont.woff’) format(‘woff’),
url(‘20db-webfont.ttf’) format(‘truetype’),
url(‘20db-webfont.svg#20_dbregular’) format(‘svg’);
font-weight: normal;
font-style: normal;
}
@font-face {
font-family: ‘open_sansbold’;
src: url(‘OpenSans-Bold-webfont.eot’);
src: url(‘OpenSans-Bold-webfont.eot?#iefix’) format(‘embedded-opentype’),
url(‘OpenSans-Bold-webfont.woff2’) format(‘woff2’),
url(‘OpenSans-Bold-webfont.woff’) format(‘woff’),
url(‘OpenSans-Bold-webfont.ttf’) format(‘truetype’),
url(‘OpenSans-Bold-webfont.svg#open_sansbold’) format(‘svg’);
font-weight: normal;
font-style: normal;
}

/* General setup */

  • {
    box-sizing: border-box;
    }

    body {
    margin: 0 auto;
    min-width: 1000px;
    max-width: 1400px;
    }

    /* Layout */

    section {
    float: left;
    width: 50%;
    }

    aside {
    float: left;
    width: 30%;
    }

    nav {
    float: left;
    width: 20%;
    }

    footer {
    clear: both;
    }

    header, section, aside, nav, footer {
    padding: 20px;
    }

    /* header and footer */

    header, footer {
    border-top: 5px solid #a66;
    border-bottom: 5px solid #a66;

    }

    /* WRITE YOUR CODE BELOW HERE */
    /Fonts and general styling/
    html{
    font-size:10px;
    }
    h1{
    font-family: ‘enigmaticregular’,;
    font-size:50;
    text-align: center;
    }
    body{
    font-family: ‘open_sansbold’, sans-serif;
    font-size:20px;
    word-spacing: 0.3rem;
    letter-spacing:0.2rem;
    line-height: 1.5;
    }
    h2{
    font-family: ‘20_dbregular’,bold;
    letter-spacing:0.2rem;
    font-size:35px;
    }
    section >p{
    text-indent:20px;
    }

/Links/
a{
outline:none;
text-decoration:none;
padding: 4px 2px 0;
}
a:link{
color:blue;
}
a:visited{
color:blueviolet
}
a:focus{
border-bottom: 1px solid;
background:pink
}
a:hover{
border-bottom:1px solid;
background:lightsalmon;
}
a:active{
background:burlywood;
color:brown;
}
a[href*= “http”]{
background: url(‘external-link-52.png’);
background-size: 16px 16px;
padding-left:19px;
background-repeat: no-repeat;
background-position:0 2px;
}

/List styling/
ul#course{
line-height: 1.5;
list-style-type:square;
list-style-position:inside;
}
aside{
font-family: serif;
}
ul#lessons{
line-height: 1.5;
list-style-type: circle;
list-style-position:inside;
font-family: serif;
}
ol li{
list-style-type: lower-alpha;
}

/Navigation menu styling/
nav{
padding-left:0;
}
nav a{
text-decoration:none;
}
nav #NavMenu a:hover,nav #NavMenu a:focus {
text-decoration: none;
background-color:rgb(163, 60, 60);
color: white;
}
nav ul li a{
display: inline-block;
line-height:5em;
width: 100%;
border: 2px solid lightcoral;
background: lightgrey;
border-radius: 3px;
text-align: center;
margin-top: 1em;
}
nav ul li{
list-style-type: none;
}

/Footer/
footer p{
font-size: 15px;
}

@Pawper Hey there!

I’ve taken a look, and this looks really nice — well done! You’ve chosen some different styles to my originals, and I think they hang together well.

1 Like

Hi there @andreeapetrescu16, and thanks for sending your code in!

It is quite difficult to mark in this format, so could you put it inside an online code plaground like codepen, or glitch, and send me the URL? Thanks!

Oh, sorry!
Here the URL https://codepen.io/Andreea96/pen/BaymoKL

@andreeapetrescu16 no worries! Thanks for sending the code in.

So this looks pretty good. Because it is in a codepen, there are some things missing from the design (the fonts are not applied, and neither is the external link icon), but the code is looking fine. Well done on a great job!