"Fundamental CSS comprehension" assessment

MDN Learn
#42

Hi @selianordev, thanks for submitting your code! This is looking mostly fine; there are just a few minor points that I wanted to talk about:

  1. The alignment of the address is not just right, and the color is the not the same as the one we used. You used the following rule:
.card article p{
color: #fff;
padding-left:1em;
padding-top:2em;
}

But it should more like this:

.card article p{
color: rgba(255,255,255,0.8);
padding:1em;
}

The color is not a major problem, but the alignment is slightly more serious.

  1. The text in the footer is slightly different to what we had in our version. Again, this is not a big problem. Looking at your code, it is down to an unneeded font-weight: 500; declaration in the following rule:
.card footer p{
font-size: 1.5em;
font-weight: 500;
line-height: 2;
}
  1. You gave your article element a slightly different color to ours:
.card article{
height: 12em;
background-color: rgba(0,0,0,0.2);
}

We used rgba(0,0,0,0.25). But again, this is only a very minor point.

Well done on a good bit of work.

1 Like
#43

Hi @chrisdavidmills, thank you so much for your input ā€¦ I am going to re-work on that ā€¦ I real appreciate your comment
thanks

css_business_card_Mozila_Developer
css_business_card_Mozila_Developer.png1366Ɨ728 112 KB
#44

Hello!
I also tried this.
Published on GitHub Pages.
fundamental-css-comprehension
Please give me an evaluation.
Thanks.

#45

Hi there @amaryllis,

I have had a look at your work, and it looks perfect! It works exactly the same as our version, and there is nothing I can really comment on here. Well done on some great work!

1 Like
#46

Hello there!

I tried this assessment, here is the page. I would like to know if it needs something more.

Thanks!

#47

Hi there @Armiixteryx,

Iā€™ve had a look at your code, and it looks pretty much perfect ā€” well done!

The only difference I noticed was that your address text is brighter, but this is definitely a good thing ā€” the contrast was a bit dull on the original.

#48

Thanks for your revision! :+1:

#49

Hi, is there somewhere i can find what the html document should look like, please ? :slight_smile:

#50

Hi there @El_muchacho, welcome to the community.

For this assessment, you can find the source code at https://github.com/mdn/learning-area/blob/master/css/introduction-to-css/fundamental-css-comprehension-finished/

#51

Hi, check my code, please

/*General page styles*/

body {
  margin: 0;
}

html {
  font-family: 'Helvetica neue', Arial, 'sans serif';
  font-size: 10px;
  background-color: #ccc;
}

h2, p {
  margin: 0;
}

/* Card container styles */

.card {
  width: 35em;
  height: 22em;
  margin: 5em auto;
  background-color: red;
  border: 0.2em solid black;
  border-radius: 1.5em;
}

/* Header and Footer styles */

.card header {
  background-image: linear-gradient(to bottom,rgba(0,0,0,0.1), rgba(0,0,0,0));
  border-radius: 1.5em 1.5em 0 0;
}

.card footer {
  background-image: linear-gradient(to bottom,rgba(0,0,0,0), rgba(0,0,0,0.1));
  border-radius: 0 0 1.5em 1.5em;
}

.card header, .card footer {
  height: 3em;
  padding: 1em;
}

.card header h2 {
  font-size: 2em;
  line-height: 1.5em;
}

.card footer p {
  font-size: 1.5em;
  line-height: 1.75em;
}

/* Main conents styles */

.card article img {
  max-height: 100%;
  float: right;
}

.card article {
  height: 12em;
  background-color: rgba(0, 0, 0, 0.5);
}

.card article p {
  color: lightcyan;
  padding: 1em;
}

/* 
Specificity:
.card article img - 12 
.card footer - 11
.card header - 11
.card - 10
*/
#52

Hi there @nikolaesku, and thanks for sending your code in!

This looks pretty much perfect, and youā€™ve got the specificity calculations right.

Your background and foreground colors are different to ours on the central area, but this is better for accessibility purposes.

The only minor thing to mention is that your footer text isnā€™t quite centered. You used the following:

.card footer p {
  font-size: 1.5em;
  line-height: 1.75em;
}

Whereas we used this:

.card footer p {
  font-size: 1.5em;
  line-height: 2;
}

The parent <footer> elementā€™s height is 3em, so if we set the text font-size to 1.5em then use a line-height of 2, we get an overall text height of 3em ā€” the unitless 2 value acts as a multiplier, so the font size of 1.5em is multiplied by 2 to equal a computed line-height value of 3em.

But apart from that, perfect. Well done!

#53

Just a headā€™s upā€¦ this assessment is somewhat ā€œhiddenā€ in the flow of the tutorial list. Even on the page that this assessment sits on, if you look on the left navigation panel, it is not there. And the last tutorial, ā€œOrganizing Your CSSā€, does not link or lead to it. I happened to find it, and bookmarked it, when I was looking up something else, completely unrelated. I checked the navigation panel to see when it would be coming up, and it wasnā€™t there. But I figured out where it was supposed to be, and have taken the assessment now.

Oddly, it shows up on the navigation panel on this page: Advanced Styling Effects

But this particular tutorial is another that is not located on the Building Blocks list, nor does anything link up to it.

I just wanted to make sure someone was aware of the serious break in the tutorial flow. It is such a fantastic series.

#54

Thanks for bringing it up!

I have listed it in the main landing page for the Building blocks module, but forgot to add it to the sidebar.

Iā€™ll sort that out now.

#55

Hi @chrisdavidmills, itā€™s been a while, but Iā€™ve been learning HTML & CSS every night of the last 34 nights :smiley: Iā€™ve finally made my way to the MDN CSS assessments.

Hereā€™s the first one, if you can please mark it:
Live: https://fundamental-css-comprehension.hashbase.io/
Code: https://github.com/Pawper/Fundamental-CSS-Comprehension/blob/master/style.css

Thank you!

#56

Hi @Pawper, nice to hear from you, and glad youā€™ve been having fun with your learning :wink:

This looks really good ā€” your example does exactly what it is supposed to do, and as a bonus, youā€™ve changed the background color in the middle section to make the contrast better. Nice work!

1 Like
#57

Hey guys I somehow managed to do this challenge but thereā€™s very minute mistake or bug in aligning the borders of header and footer with the cardā€¦

Screenshot 2019-12-12 at 21.50.01
Screenshot 2019-12-12 at 21.50.01922Ɨ554 58.8 KB

Can someone help me with error ?

https://codepen.io/rohit1101/pen/rNaLpjX?editors=1100

Check out my code in the above linkā€¦

#58

Hi there @srohit1101!

Your problem here stems from the fact that youā€™ve got the card class set on not only the <section> element, but also the <header> and <footer> elements too. So the styles applied to the overall card are being applied to those elements too, leading to some strange visual effects.

Removing the card class from <header> and <footer> should solve most of your problems.

After that, you can probably simplify your CSS too, as you wonā€™t need the stuff that is trying to override the card styles.