Fairphone 2 build

lissyx · August 24, 2016, 8:53am

@Novski Can you also ensure, if you are using an updated upstream blobset, that the layout of |TARGET_DEVICE_BLOBS_SRC_DIR := vendor/qcom/proprietary/target/product/FP2/| has not been changed ? Maybe they just modified the paths and this is why it screws you for generating the blob list file.

Download and extract the set of blobs references in download-blobs.sh and compare the tree structure with your new blobs

lissyx · August 24, 2016, 10:22am

No, that is not your problem. Assertion failures would only happen on a B2G_DEBUG=1 build. A non debug build (which is the default) would work.

Novski · August 24, 2016, 11:52am

Thats why im asking… I can abort here if there is no need, but i think it’s better to have somebody working slow than nobody at all. Mozilla support is gone and the only people left are some entusiasticaly connected peoples. There are verry few programmers with knowledge of B2G anyway so if you take some more time to explaine me the details (and the words used as synonym so oftenly) i will learn how to manage code faster.

i found echos in that file that seam to be same as b2g-installer popups…

does that mean that the proptietay-files.txt file is generated during the build? I don’t think so…

what does “upstream” mean, the only upstream i know is in water…

Thanks for clarification. I will start debuging that when i have more time…

patata · August 24, 2016, 11:58am

Hello,
i’m struggling to flash fxos on my fp2.
I have downgraded to 1.2.8 and “USB debbugging connected” on the screen.
i have Ubuntu, i run nightly with ADB helper. In a new profile i open about:b2g-installer, connect my device. The files are opening, but the b2g-installer still doesn’t see the device.

I’m a simple user, have no specific knowledge on the topic. I’ve been told to run this:

patata@librem13:~$ adb devices

daemon not running. starting it now on port 5037 *

daemon started successfully *
List of devices attached

Then i’ve been told to add udev rules, but i don’t know how to do that. i’d like to see full procedure in the manual.

lissyx · August 24, 2016, 12:13pm

Please use the VM to make sure.

Novski · August 24, 2016, 12:17pm

go to settings and scroll all the way down. Tap on the last entry of the list and scroll all down to the buildNr. and tap that one 10 times.
As soon as you have developer go back to settings “first page” and tap on developer. Second last entry.
Enable USB Debuging.
Then you have to uncheck all options in the connection notification pull down.

It will then be recognized but the available B2G OS version has a bug and will not pull the blobs correctly so ther is no point to flash your device by now… I will fix that soon.

lissyx · August 24, 2016, 12:25pm

The problem is that most of your questions are not B2G specific at all. Basic knowledge of make, gcc, git are really needed to be able to pursue, but it has nothing specific with the project. And if you lack those knowledges, then it’s even harder for us to help you

What are the “echos in that file that seems to be same as b2g-installer popups” ? I really doubt, because I wrote both

The proprietary-file.txt is being used by the build system to copy/install the blobs, and read . Blob-free detection of blobs does not rely on this. Basically, what the gonk-misc/Android.mk shell magic does is that is computes sha1 to identify the blobs. So we read the filenames from proprietary-file.txt, but we re-build a mapping of blobs.

patata · August 24, 2016, 1:12pm

uncheck all options in the connection notification pull down

Thanks Novski, that was it!

lissyx · August 24, 2016, 1:12pm

It is not that I don’t want to help you, but you are asking me to teach you git, make, etc. ; which I am sorry, but I am not fitted for. I see you wanting to help, and I am happy to help you into the B2G-specifics details, but sorry, there are other prereq needed and you have to learn them by yourself ; namely, I already linked you online books for Git for example.

You need to separate what you designates as details in two sets: general knowledges ; B2G-specifics. There are a lot of the those, B2G-specifics, but once you have general knowledges, it’s not that hard to navigate through.

I really like what you are doing, taking care of B2G, and obviously you are making progresses, but there is a point where I cannot help you more if you dont, on your own side, learn some basics (again, those will be useful anywhere). There is nothing fundamentally complex either in those, but you need to understand. Giving you quick exact solution is not really helping you if you don’t know what it means

So, to summarize: the resulting list of blobs in the blobfree distribution has an extra system/ ; this is coming from the code living in gonk-misc/Android.mk that plays around the blobs. You need to read the code there (it’s shell in makefile, not trivial but nothing impossible) and specifically the target |$(TARGET_DEVICE_BLOBS_OUT)|. Basically this is producing the list of blobs read by the addon.

The bug 1240352 is the one where the CM-compatible method was introduced (relying on proprietary-files.txt). For fairphone2 the definition is here: https://github.com/mozilla-b2g/device-fairphone2/blob/master/FP2.mk#L16

So it means you need to check the content of the intermediary files like $(PRODUCT_OUT)/$(TARGET_DEVICE)-blobs-sha1-out.txt and others, and verify why you get an extra system/ there.

You also have not yet documented:

are you building with the same blobs as Juan did? Again, it is very possible they changed the layout somehow.
directory listing of the blobs Juan used
directory listing of the blobs you are using

lissyx · August 24, 2016, 1:25pm

And again, I cannot but advise you to read all comments on the blobfree parts of Android.mk at https://github.com/mozilla-b2g/gonk-misc/blob/master/Android.mk#L172 that explains, hopefully, a lot of why and how.

Novski · August 25, 2016, 12:14pm

As first i whant to make the build work smoth. For that i created the pull request (PR) of fairphone.xml in the bug. https://bugzilla.mozilla.org/show_bug.cgi?id=1294725#add_comment
I don’t know how it now gets to the mozilla-b2g/b2g-manifest but i think somebody here will be able to tell me how that works…

lissyx · August 26, 2016, 8:29am

That is merged now

Novski · September 5, 2016, 8:57am

Hi to all, I introduced an issue in the fairphone.xml file thats now fixed. The merge of PR https://github.com/mozilla-b2g/b2g-manifest/pull/453 will soon be done and at that point Fairphone is ported successfuly to B2G.
Alltroug we will still have to do some work to get the latest bloobs pulled. It will be possible to test and Develop around FP2.

Future of B2GOS on Fairphone 2:
As there was a good update to FPOS1.6.1 wich made the proximity sensor working great, i wold like to wait until the Fairphone Open 16.08 will be released with the same blobs as FPOS1.6.1 and then build the new blob-download upon that point. Also the blobfree-build will be made upon that point soon after.
In the mean time i will try to make the blobfree-build work upon the momentary build of B2G.

Luca · September 5, 2016, 2:49pm

Good Job, @Novski, thank you very much for your efforts!

Novski · September 6, 2016, 3:17pm

Well the good news is I tested it. The bad news is it still doesn’t build.

It throughs me the WebRTC error you once mentioned is because of libatomic stuff (Post 50)

I think i now understand this post

This is what worked by applying manualy:

As @lissyx made me the fork in B2G i didn’t thaught of the second dependency. And since i remove framework/native in my fairphone.xml i think i remove the part that fixes that C++ problem as well.
Is that thaught right?
What can i do?

lissyx · September 6, 2016, 3:22pm

That would be surprising since your manifest does reference FP2 specific branch for frameworks/native:

github.com

mozilla-b2g/b2g-manifest/blob/master/fairphone2.xml#L8


<?xml version="1.0" encoding="UTF-8"?>
<manifest>
<include name="base-l-aosp.xml"/>
<default remote="caf" revision="LA.BF.1.1.1_rb1.18" sync-j="4"/>


<!-- Fairphone repos with specific changes -->
<remove-project name="platform_frameworks_native"/>  
<project name="platform_frameworks_native" path="frameworks/native" remote="b2g" revision="b2g-fp2" />
<project name="codeaurora_kernel_msm" path="kernel" remote="b2g" revision="b2g-msm-fairphone2-3.4-lollipop" />
<remove-project name="platform_system_core" />
<project groups="pdk" name="platform_system_core" path="system/core" remote="b2g" revision="b2g-fp2-sibon" />
<remove-project name="platform_frameworks_av" />
<project name="platform_frameworks_av" path="frameworks/av" remote="b2g" revision="b2g-fp2-sibon" />
<remove-project name="platform/external/skia" />
<project groups="pdk-cw-fs,qcom_msm8x26" name="external_skia" path="external/skia" remote="b2g" revision="fp2-sibon" />
<project groups="pdk" name="platform_external_wpa_supplicant_8" path="external/wpa_supplicant_8" remote="b2g" revision="fp2-sibon" />
<project groups="qcom,default" name="hardware_qcom_audio" path="hardware/qcom/audio" remote="b2g" revision="fp2-sibon" />
<project groups="qcom,default" name="hardware_qcom_bt" path="hardware/qcom/bt" remote="b2g" revision="fp2-sibon" />

That’s under the assumption you really experience the exact same error, of course

Make sure |./config.sh fairphone2| executes completely and correctly, maybe you messed up something by switching between repos and branches. I know it’s not fun but in the worst case, start from scratch

lissyx · September 6, 2016, 3:24pm

That being said, checking:

I don’t see the commit e92af361af5155574c3f05b9544aef194b760aa0

Did you finished the PR ? This might be what happens when I don’t have a review flag set properly

Novski · September 7, 2016, 7:47am

no i wasn’t ware of the need. Now i did it. https://bugzilla.mozilla.org/show_bug.cgi?id=1294725
You may have got a few strange PR and reverts because i had trouble to make the PR to the b2g-fp2 branch.
Please excuse the fload of e-mails…

Novski · September 7, 2016, 8:00am

just saw that you wrote me an e-mail.
Lets stay here in discourse…

It’s okay but make sure you have cherry-picked the fix as you did on
discourse, not just applying the same changes.

Might look like a detail but it is quite important for good tracking of
issues and fixes

The cherry-pick never worked… i did it manualy. Should i close the PR and try to cherry-pick again?

lissyx · September 7, 2016, 8:19am

Yes please cherry pick again

You have been able to do it in the past so no reason you cannot again!

If you still have that branch you made with the cherry pick just use it and
push to your repo there you can do the pr

<
https://ci5.googleusercontent.com/proxy/kY0yCMmDzLJk1E96ido5ikNAHe5zh52D3YphR1X2xsrOEU-akWaRVcb05gCxw4tWSLqENnwem5Tm-NtFWoV2NCt4Wc-JGW_Dh5C7jzgcntlxIgUGOQWTDe7tfUEQonn_B38KBuLWG02k6YjYTd1RxOikuyZQHm2_UG72p17U=s0-d-e1-ft#https://discourse.mozilla-community.org/user_avatar/discourse.mozilla-community.org/novski/45/4829_1.png>
Novski
September 7

just saw that you wrote me an e-mail.
Lets stay here in discourse…

It’s okay but make sure you have cherry-picked the fix as you did on
discourse, not just applying the same changes.

Might look like a detail but it is quite important for good tracking of
issues and fixes <
https://ci4.googleusercontent.com/proxy/WXb7N19ymmSjQefzE6_DMhC7WlvMLvTzF_d-xpixnAW2xonFpj0ouJSL5EEFo3qKpy393sIX7TX4NIGY5ZvxpotgugqQUVeKIwjRFdw2Q2lD8LmfQvs1fCzhXHIWDSTtOurmKFdniNA_=s0-d-e1-ft#https://discourse.mozilla-community.org/images/emoji/emoji_one/slight_smile.png?v=2

The cherry-pick never worked… i did it manualy. Should i close the PR
and try to cherry-pick again?

Visit Topic or reply to this email to respond.

In Reply To

<
https://ci5.googleusercontent.com/proxy/kY0yCMmDzLJk1E96ido5ikNAHe5zh52D3YphR1X2xsrOEU-akWaRVcb05gCxw4tWSLqENnwem5Tm-NtFWoV2NCt4Wc-JGW_Dh5C7jzgcntlxIgUGOQWTDe7tfUEQonn_B38KBuLWG02k6YjYTd1RxOikuyZQHm2_UG72p17U=s0-d-e1-ft#https://discourse.mozilla-community.org/user_avatar/discourse.mozilla-community.org/novski/45/4829_1.png>
Novski
September 7
no i wasn’t ware of the need. Now i did it.
https://bugzilla.mozilla.org/show_bug.cgi?id=1294725 You may have got a few
strange PR and reverts because i had trouble to make the PR to the b2g-fp2
branch. Please excuse the fload of e-mails…